Bug 61957 - [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
Summary: [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P1 Blocker
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-06-02 13:27 PDT by Alexis Menard (darktears)
Modified: 2011-06-03 08:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2011-06-02 13:35 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2011-06-03 04:48 PDT, Alexis Menard (darktears) 		benjamin: review+
benjamin: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-06-02 13:27:14 PDT 
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
Comment 1 Alexis Menard (darktears) 2011-06-02 13:35:11 PDT 
Created attachment 95799 [details]
Patch
Comment 2 Andreas Kling 2011-06-02 13:37:17 PDT 
Comment on attachment 95799 [details]
Patch

r=me, brah
Comment 3 Alexis Menard (darktears) 2011-06-02 13:38:22 PDT 
Committed r87950: <http://trac.webkit.org/changeset/87950>
Comment 4 Csaba Osztrogonác 2011-06-02 15:46:17 PDT 
(In reply to comment #3)
> Committed r87950: <http://trac.webkit.org/changeset/87950>

It broke Mac build. :-/
cc1plus: error: unrecognized command line option "-Wno-c++0x-compat"

Reopen to fix it.
Comment 5 Alexis Menard (darktears) 2011-06-03 02:20:12 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Committed r87950: <http://trac.webkit.org/changeset/87950>
> 
> It broke Mac build. :-/
> cc1plus: error: unrecognized command line option "-Wno-c++0x-compat"
> 
> Reopen to fix it.

How is it possible? Mac runs GCC 4.6.0?
Comment 6 Csaba Osztrogonác 2011-06-03 02:35:19 PDT 
I don't know ... Dihan?
Comment 7 Alexis Menard (darktears) 2011-06-03 03:55:23 PDT 
And it's protected in a linux { } condition so I close it unless someone show me exactly what's going on.
Comment 8 Alexis Menard (darktears) 2011-06-03 04:48:16 PDT 
Created attachment 95888 [details]
Patch
Comment 9 Benjamin Poulain 2011-06-03 04:57:50 PDT 
Comment on attachment 95888 [details]
Patch

Looks ok. Let's see if the bot likes it :)
Comment 10 Alexis Menard (darktears) 2011-06-03 05:04:53 PDT 
Committed r88006: <http://trac.webkit.org/changeset/88006>
Comment 11 Ademar Reis 2011-06-03 06:44:38 PDT 
Revision r87950 cherry-picked into qtwebkit-2.2 with commit cf23541 <http://gitorious.org/webkit/qtwebkit/commit/cf23541>
Revision r88006 cherry-picked into qtwebkit-2.2 with commit 5902ab9 <http://gitorious.org/webkit/qtwebkit/commit/5902ab9>
Comment 12 Dihan Wickremasuriya 2011-06-03 08:49:29 PDT 
(In reply to comment #6)
> I don't know ... Dihan?

I know this issue has been resolved, but in case anyone still needs this info the version of gcc/g++ on the Mac build slave is 4.2.1 build 5664.

Detailed software/hardware specs for the Mac slave are now available on the bot:
http://build.webkit.sed.hu/buildslaves/szeged-xserve-1