Remember the scroll position and restore after exiting full-screen mode.
<rdar://problem/9544461>
Created attachment 95797 [details] Patch
Correction: <rdar://problem/9504664>
What about WebKit1 on Windows?
(In reply to comment #4) > What about WebKit1 on Windows? Actually, both WebKit1 & 2 on Windows would need more work. Let me look into it.
Created attachment 99233 [details] Patch
Comment on attachment 99233 [details] Patch What makes scroll position special? Is there any other state that needs to be saved and restored?
Who should review this 6 month old patch? Should it be r-'d?
(In reply to comment #7) > (From update of attachment 99233 [details]) > What makes scroll position special? Is there any other state that needs to be saved and restored? @Darin: Scroll position is modified when entering and exiting full-screen, which is what makes it special. At this time, I'm not aware of any other state which needs saving in the same way.
Turns out there's at least one more property which needs to be saved and restored: bug #106115.
Created attachment 188356 [details] Patch Rebaselined
What if the page scrolls while some element is in fullscreen?
Generally speaking, this won't happen, as we set a 'overflow:hidden' rule on the document root.
This would be really helpful for Vimeo when people embed videos on their own pages.
Comment on attachment 188356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188356&action=review > Source/WebKit2/ChangeLog:44 > + Reviewed by NOBODY (OOPS!). > + > + Remember the scroll position and restore after exiting full-screen mode. > + https://bugs.webkit.org/show_bug.cgi?id=61956 > + > + Add support for two new FullScreenClient callbacks for saving and restoring the > + full-screen frame's scroll position. > + > + * UIProcess/win/WebView.cpp: > + (WebKit::WebView::fullScreenClientSaveScrollPosition): > + (WebKit::WebView::fullScreenClientRestoreScrollPosition): > + * UIProcess/win/WebView.h: > + > +2011-06-29 Jeremy Noble <jer.noble@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Remember the scroll position and restore after exiting full-screen mode. > + https://bugs.webkit.org/show_bug.cgi?id=61956 > + <rdar://problem/9544461> > + > + Call into the main FrameView to save the scroll position before swapping the > + WebView into the full-screen window, and restore the scroll position after > + swapping the WebView back into the browser window. > + > + * UIProcess/mac/WKFullScreenWindowController.mm: > + (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): > + (-[WKFullScreenWindowController beganExitFullScreenAnimation]): > + > + In WebKit2, this requires some communication between the WebProcess and the > + UIProcess, so add two new messages to WebFullScreenManager to be called by > + its proxy. > + > + * UIProcess/WebFullScreenManagerProxy.h: > + * UIProcess/WebFullScreenManagerProxy.cpp: > + (WebKit::WebFullScreenManagerProxy::saveScrollPosition): > + (WebKit::WebFullScreenManagerProxy::restoreScrollPosition): > + * WebProcess/FullScreen/WebFullScreenManager.h: > + * WebProcess/FullScreen/WebFullScreenManager.messages.in: > + * WebProcess/FullScreen/WebFullScreenManager.cpp: > + (WebKit::WebFullScreenManager::saveScrollPosition): > + (WebKit::WebFullScreenManager::restoreScrollPosition): Two changelogs!
Committed r152520: <http://trac.webkit.org/changeset/152520>
Hi, this is still happening. Demo: https://codepen.io/matt-west/pen/hmqsF Is it really resolved? Thanks.