Bug 61954 - [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
Summary: [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 13:09 PDT by Adrienne Walker
Modified: 2011-06-02 15:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2011-06-02 13:13 PDT, Adrienne Walker 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-06-02 13:09:54 PDT 
[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
Comment 1 Adrienne Walker 2011-06-02 13:13:59 PDT 
Created attachment 95795 [details]
Patch
Comment 2 James Robinson 2011-06-02 14:02:24 PDT 
Comment on attachment 95795 [details]
Patch

Looks good.  Is there any reasonable way to share the CCHeadsUpDisplay uploading logic with the code we use for content layers so we don't have to do this stuff twice?
Comment 3 Adrienne Walker 2011-06-02 14:09:44 PDT 
We could probably add a tiler to the CCHeadsUpDisplay and replace all the drawing and uploading code.  That looked like a lot more invasive of a change, so I thought I'd just fix the crash initially and consider refactoring later.
Comment 4 Adrienne Walker 2011-06-02 15:14:20 PDT 
Committed r87960: <http://trac.webkit.org/changeset/87960>