Bug 61949 - Rename IntPoint/IntRect/FloatPoint/FloatRect::move to moveBy
Summary: Rename IntPoint/IntRect/FloatPoint/FloatRect::move to moveBy
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on: 61891
Blocks: 61893
  Show dependency tree / graph
 
Reported: 2011-06-02 11:41 PDT by Emil A Eklund
Modified: 2011-06-08 13:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (147.23 KB, patch)
2011-06-02 15:11 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-06-02 11:41:27 PDT 
From comment on bug 61893:

Bleh.  I'm liking generic move(IntPoint) less and less.  it's not clear if it sets or moves.
I think we should consider renaming the move() calls to moveBy() or something to make it clear what move(Point) is doing.  (I know rect and IntPoint use the same naming, so maybe that should be a separate change?)
Comment 1 Emil A Eklund 2011-06-02 15:04:00 PDT 
Follows up on the work started by levi in bug 61891.
Comment 2 Emil A Eklund 2011-06-02 15:11:52 PDT 
Created attachment 95820 [details]
Patch
Comment 3 Emil A Eklund 2011-06-02 15:12:36 PDT 
Upload early to get feedback on whether this is a good idea or not. I suspect there are other platform specific files that needs to be updated as well.
Comment 4 WebKit Review Bot 2011-06-02 15:30:13 PDT 
Comment on attachment 95820 [details]
Patch

Attachment 95820 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8756833