Bug 61945 – [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop webgl

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Idrees]

Created attachment 95780 [details]
Test case

LayoutTests/fast/canvas/webgl/point-size.html is failing for desktop qtwebkit.

GL_VERTEX_PROGRAM_POINT_SIZE is not enabled for desktop qt opengl.

[Idrees]

On furhter investigation i found out that it is not required for opengl es to enable GL_VERTEX_PROGRAM_POINT_SIZE or GL_POINT_SPRITE. but for opengl desktop we need to enable this feature.

[Idrees]

Created attachment 95782 [details]
Fix for the bug.

I have enabled the feature only for desktop QtWebKit Webgl.

[Andreas Kling]

Comment on attachment 95782 [details]
Fix for the bug.

View in context: https://bugs.webkit.org/attachment.cgi?id=95782&action=review

Is this not testable?

> Source/WebCore/ChangeLog:5
> +        [QT] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop webgl

QT -> Qt
webgl -> WebGL

> Source/WebCore/ChangeLog:9
> +        For Opengl ES we do not need these features. 
> +        These features are available via shadders in Opengl ES. But for desktop WebGL using QtWebkit they should be enabled.

Opengl -> OpenGL
shadders -> shaders
QtWebkit -> QtWebKit

[Idrees]

(In reply to comment #3)
> (From update of attachment 95782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95782&action=review
> 
> Is this not testable?

I am doing the development and testing on linux desktop with OpenGL. So it is testable there. For OpenGL ES, I found out that its not required. But i have not tested it with OpenGL ES. For linux desktop with OpenGL it is definitely testable.

[Idrees]

Created attachment 95790 [details]
Patch for the fix.

Fixing typos.

[Idrees]

Created attachment 95792 [details]
Fix for the bug.

more typos.

[WebKit Review Bot]

Comment on attachment 95792 [details]
Fix for the bug.

Clearing flags on attachment: 95792

Committed r88335: <http://trac.webkit.org/changeset/88335>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.