WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61928
[GTK] Web Inspector tests failing in GTK bots after
r87901
https://bugs.webkit.org/show_bug.cgi?id=61928
Summary
[GTK] Web Inspector tests failing in GTK bots after r87901
Mario Sanchez Prada
Reported
2011-06-02 08:43:58 PDT
Right after committing changes in
r87901
(
http://trac.webkit.org/changeset/87901
), the following tests started to fail: inspector/audits/audits-panel-functional.html inspector/extensions/extensions-resources.html For some time there were similar (not identical, though) failures in the "SnowLeopard Intel Debug WK2 Tests" bot, but they quickly went away. However the failures in GTK bots remain consistently, so filing a bug (this bug) and skipping them temporarily for GTK. The diff outputs at the moment in GTK bots are as follows: --- /tmp/msanchez/inspector/audits/audits-panel-functional-expected.txt 2011-06-02 07:28:59.151741468 -0700 +++ /tmp/msanchez/inspector/audits/audits-panel-functional-actual.txt 2011-06-02 07:28:59.151741468 -0700 @@ -1,9 +1,9 @@ Tests audit rules. Page reloaded. Network Utilization - Combine external JavaScript (4) + Combine external JavaScript (7) There are multiple resources served from same domain. Consider combining them into as few files as possible. - 4 JavaScript resources served from [domain]. + 7 JavaScript resources served from [domain]. Specify image dimensions (2) A width and height should be specified for all images in order to speed up page display. The following image(s) are missing a width and/or height: foo1.jpg --- /tmp/msanchez/inspector/extensions/extensions-resources-expected.txt 2011-06-02 07:29:06.447741214 -0700 +++ /tmp/msanchez/inspector/extensions/extensions-resources-actual.txt 2011-06-02 07:29:06.447741214 -0700 @@ -6,6 +6,8 @@ Running tests... RUNNING TEST: extension_testGetHAR resource: .../tests/inspector/extensions-resources-test.js +resource: .../tests/inspector/extensions-resources-test.js +resource: .../tests/inspector/extensions-test.js resource: .../tests/inspector/extensions-test.js resource: .../tests/inspector/inspector-test.js resource: .../inspector/extensions/extensions-resources.html
Attachments
Add attachment
proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1
2011-06-02 08:46:44 PDT
Adding James Robinson to CC, in case he could drop some light on this, as the author of
r87901
Mario Sanchez Prada
Comment 2
2011-06-02 09:46:31 PDT
Yet another test failing because of the same reason: http/tests/inspector/extensions-resources-redirect.html The diff output this time is: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/inspector/extensions-resources-redirect-expected.txt 2011-06-02 09:25:39.293366493 -0700 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/inspector/extensions-resources-redirect-actual.txt 2011-06-02 09:25:39.293366493 -0700 @@ -13,6 +13,7 @@
http://127.0.0.1:8000/inspector/extensions-resources-redirect.html
http://127.0.0.1:8000/inspector/extensions-resources-test.js
http://127.0.0.1:8000/inspector/extensions-test.js
+
http://127.0.0.1:8000/inspector/extensions-test.js
http://127.0.0.1:8000/inspector/inspector-test.js
http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true
http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true
James Robinson
Comment 3
2011-06-02 11:19:51 PDT
Interesting, I'll take a look.
James Robinson
Comment 4
2011-06-02 20:17:16 PDT
I don't really understand why GTK would behave differently from other ports, but I had to revert 87901 for other reasons so it's probably OK now.
Mario Sanchez Prada
Comment 5
2011-06-03 00:50:04 PDT
(In reply to
comment #4
)
> I don't really understand why GTK would behave differently from other ports, > but I had to revert 87901 for other reasons so it's probably OK now.
I run those three tests in the bots several times and they're passing now. Now unskipping them and marking this bug as resolved, as your last commit clearly fixed it:
http://trac.webkit.org/changeset/87990
Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug