WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61912
[Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=61912
Summary
[Refactoring] Node::nextRenderer() and previousRenderer() should be part of N...
Hajime Morrita
Reported
2011-06-02 00:29:43 PDT
This is a preparation for upcoming fix.
Attachments
Patch
(5.82 KB, patch)
2011-06-02 01:04 PDT
,
Hajime Morrita
tkent
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2011-06-02 01:04:14 PDT
Created
attachment 95735
[details]
Patch
Kent Tamura
Comment 2
2011-06-02 01:34:53 PDT
Comment on
attachment 95735
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=95735&action=review
> Source/WebCore/dom/NodeRenderingContext.cpp:118 > + for (Node* n = m_node->nextSibling(); n; n = n->nextSibling()) {
nit: one-letter variable name
> Source/WebCore/dom/NodeRenderingContext.cpp:143 > + for (Node* n = m_node->previousSibling(); n; n = n->previousSibling()) {
ditto.
Hajime Morrita
Comment 3
2011-06-02 01:57:26 PDT
Hi Kent-san, thank you for reviewing! (In reply to
comment #2
)
> (From update of
attachment 95735
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=95735&action=review
> > > Source/WebCore/dom/NodeRenderingContext.cpp:118 > > + for (Node* n = m_node->nextSibling(); n; n = n->nextSibling()) { > > nit: one-letter variable name
Woa, will rename before landing...
Hajime Morrita
Comment 4
2011-06-02 02:14:43 PDT
Committed
r87885
: <
http://trac.webkit.org/changeset/87885
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug