Bug 61885 – [Windows, WinCairo] Add C++ Event Listener Example to WinLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

Update the WinLauncher example program with an event listener attached to the WebKit logo.  This shows how to find a DOM object, attach a C++ (COM) based event listener, and process the result.

[Brent Fulgham]

Created attachment 95667 [details]
Patch

[Brian Weinstein]

Comment on attachment 95667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95667&action=review

> Tools/ChangeLog:7
> +

A sentence or two about the example you added would be nice here. Talking about adding an on click event for the WebKit logo, and how someone can test this.

> Tools/WinLauncher/WinLauncher.cpp:177
> +    frame->DOMDocument(&doc);

Do you want to check if the frame is the main frame here? Or does it not matter?

[Brent Fulgham]

(In reply to comment #2)
> (From update of attachment 95667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95667&action=review
> 
> > Tools/ChangeLog:7
> > +
> 
> A sentence or two about the example you added would be nice here. Talking about adding an on click event for the WebKit logo, and how someone can test this.

Done.

> > Tools/WinLauncher/WinLauncher.cpp:177
> > +    frame->DOMDocument(&doc);
> 
> Do you want to check if the frame is the main frame here? Or does it not matter?

I don't believe it matters.

Thanks for looking all of this over!

[Brent Fulgham]

Landed in http://trac.webkit.org/changeset/89144.