Bug 61885 - [Windows, WinCairo] Add C++ Event Listener Example to WinLauncher
Summary: [Windows, WinCairo] Add C++ Event Listener Example to WinLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: CPPEventListeners
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-01 14:18 PDT by Brent Fulgham
Modified: 2011-06-17 16:24 PDT (History)
0 users

See Also:


Attachments
Patch (11.04 KB, patch)
2011-06-01 14:52 PDT, Brent Fulgham
bweinstein: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2011-06-01 14:18:39 PDT
Update the WinLauncher example program with an event listener attached to the WebKit logo.  This shows how to find a DOM object, attach a C++ (COM) based event listener, and process the result.
Comment 1 Brent Fulgham 2011-06-01 14:52:14 PDT
Created attachment 95667 [details]
Patch
Comment 2 Brian Weinstein 2011-06-14 10:23:37 PDT
Comment on attachment 95667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95667&action=review

> Tools/ChangeLog:7
> +

A sentence or two about the example you added would be nice here. Talking about adding an on click event for the WebKit logo, and how someone can test this.

> Tools/WinLauncher/WinLauncher.cpp:177
> +    frame->DOMDocument(&doc);

Do you want to check if the frame is the main frame here? Or does it not matter?
Comment 3 Brent Fulgham 2011-06-17 16:24:31 PDT
(In reply to comment #2)
> (From update of attachment 95667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95667&action=review
> 
> > Tools/ChangeLog:7
> > +
> 
> A sentence or two about the example you added would be nice here. Talking about adding an on click event for the WebKit logo, and how someone can test this.

Done.

> > Tools/WinLauncher/WinLauncher.cpp:177
> > +    frame->DOMDocument(&doc);
> 
> Do you want to check if the frame is the main frame here? Or does it not matter?

I don't believe it matters.

Thanks for looking all of this over!
Comment 4 Brent Fulgham 2011-06-17 16:24:59 PDT
Landed in http://trac.webkit.org/changeset/89144.