Bug 61884 - Switch paintOverflowControls to use IntPoint
Summary: Switch paintOverflowControls to use IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on: 61883
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-06-01 13:54 PDT by Levi Weintraub
Modified: 2011-06-01 16:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.46 KB, patch)
2011-06-01 14:49 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch (7.46 KB, patch)
2011-06-01 14:54 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-01 13:54:04 PDT 
Ongoing tx/ty removal.
Comment 1 Levi Weintraub 2011-06-01 14:49:16 PDT 
Created attachment 95666 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-01 14:51:12 PDT 
Comment on attachment 95666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95666&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2284
> +        m_cachedOverlayScrollbarOffset = paintOffset;

eeewww.  Wonder why this exists.

> Source/WebCore/rendering/RenderLayer.cpp:2295
> +        adjustedPaintOffset.move(m_cachedOverlayScrollbarOffset);

This doesn't look right.  I think you meant =.

> Source/WebCore/rendering/RenderLayerBacking.cpp:1105
> +    int tx = layerBounds.x() - m_owningLayer->renderBoxX();
> +    int ty = layerBounds.y() - m_owningLayer->renderBoxY();

I guess we're not ready to kill the tx, ty here yet? :)
Comment 3 Levi Weintraub 2011-06-01 14:53:31 PDT 
Comment on attachment 95666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95666&action=review

Thanks for the catch!

>> Source/WebCore/rendering/RenderLayer.cpp:2284
>> +        m_cachedOverlayScrollbarOffset = paintOffset;
> 
> eeewww.  Wonder why this exists.

I'll second that... Seems pretty funky to me!

>> Source/WebCore/rendering/RenderLayer.cpp:2295
>> +        adjustedPaintOffset.move(m_cachedOverlayScrollbarOffset);
> 
> This doesn't look right.  I think you meant =.

D'oh! Good catch!

>> Source/WebCore/rendering/RenderLayerBacking.cpp:1105
>> +    int ty = layerBounds.y() - m_owningLayer->renderBoxY();
> 
> I guess we're not ready to kill the tx, ty here yet? :)

paintLayer will unfortunately probably be one of the last, but we're making great progress! :)
Comment 4 Levi Weintraub 2011-06-01 14:54:33 PDT 
Created attachment 95668 [details]
Patch
Comment 5 Eric Seidel (no email) 2011-06-01 15:51:00 PDT 
Comment on attachment 95668 [details]
Patch

OK.
Comment 6 Levi Weintraub 2011-06-01 16:16:02 PDT 
Comment on attachment 95668 [details]
Patch

Clearing flags on attachment: 95668

Committed r87864: <http://trac.webkit.org/changeset/87864>
Comment 7 Levi Weintraub 2011-06-01 16:16:06 PDT 
All reviewed patches have been landed.  Closing bug.