Bug 61881 - gyp_webkit reports errors when advancing chromium_rev past version 87140
Summary: gyp_webkit reports errors when advancing chromium_rev past version 87140
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 13:32 PDT by Aaron Colwell
Modified: 2011-06-02 10:41 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2011-06-01 13:38 PDT, Aaron Colwell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2011-06-01 13:32:26 PDT
A change was made in chromium version 87140 that breaks the WebKit build if you try to advance chromium_rev in Source/WebKit/chromium/DEPS past this version. A patch will be submitted shortly to bring gyp_webkit in line with the changes made to gyp_chromium.
Comment 1 Aaron Colwell 2011-06-01 13:37:07 PDT
Original Chromium bug http://code.google.com/p/chromium/issues/detail?id=84611
Comment 2 Aaron Colwell 2011-06-01 13:38:40 PDT
Created attachment 95652 [details]
Patch
Comment 3 Aaron Colwell 2011-06-02 09:27:37 PDT
ping. C
Comment 4 Nico Weber 2011-06-02 09:30:41 PDT
This change is correct – lgtm.
Comment 5 Dimitri Glazkov (Google) 2011-06-02 09:31:33 PDT
Comment on attachment 95652 [details]
Patch

I HAZ RUBBER STAMP.
Comment 6 Aaron Colwell 2011-06-02 09:36:57 PDT
Thanks.
Comment 7 WebKit Commit Bot 2011-06-02 10:41:05 PDT
Comment on attachment 95652 [details]
Patch

Clearing flags on attachment: 95652

Committed r87927: <http://trac.webkit.org/changeset/87927>
Comment 8 WebKit Commit Bot 2011-06-02 10:41:11 PDT
All reviewed patches have been landed.  Closing bug.