RESOLVED FIXED Bug 61874
Switch paintScrollCorner to use IntPoint 
https://bugs.webkit.org/show_bug.cgi?id=61874
Summary Switch paintScrollCorner to use IntPoint
Levi Weintraub
Reported 2011-06-01 11:35:17 PDT
More tx/ty removal...
Attachments
Patch (4.06 KB, patch)
2011-06-01 11:54 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-01 11:54:09 PDT
Created attachment 95638 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-01 12:26:43 PDT
Comment on attachment 95638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review OK. > Source/WebCore/rendering/RenderLayer.cpp:2338 > + IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height()); This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset)
Levi Weintraub
Comment 3 2011-06-01 12:35:37 PDT
Comment on attachment 95638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review >> Source/WebCore/rendering/RenderLayer.cpp:2338 >> + IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height()); > > This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset) Agreed! I'll change it and land. Thanks for the review!
Levi Weintraub
Comment 4 2011-06-01 13:38:25 PDT
Committed r87841: <http://trac.webkit.org/changeset/87841>
Note You need to log in before you can comment on or make changes to this bug.