Bug 61874 - Switch paintScrollCorner to use IntPoint
Summary: Switch paintScrollCorner to use IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-06-01 11:35 PDT by Levi Weintraub
Modified: 2011-06-01 14:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2011-06-01 11:54 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-01 11:35:17 PDT 
More tx/ty removal...
Comment 1 Levi Weintraub 2011-06-01 11:54:09 PDT 
Created attachment 95638 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-01 12:26:43 PDT 
Comment on attachment 95638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review

OK.

> Source/WebCore/rendering/RenderLayer.cpp:2338
> +    IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height());

This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset)
Comment 3 Levi Weintraub 2011-06-01 12:35:37 PDT 
Comment on attachment 95638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2338
>> +    IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height());
> 
> This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset)

Agreed! I'll change it and land. Thanks for the review!
Comment 4 Levi Weintraub 2011-06-01 13:38:25 PDT 
Committed r87841: <http://trac.webkit.org/changeset/87841>