Bug 61870 - LayoutTests/editing/pasteboard/drag-drop-list fails on GTK
Summary: LayoutTests/editing/pasteboard/drag-drop-list fails on GTK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61661
Blocks: 61683
  Show dependency tree / graph
 
Reported: 2011-06-01 10:49 PDT by Annie Sullivan
Modified: 2011-06-01 12:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2011-06-01 10:51 PDT, Annie Sullivan 		no flags Details | Formatted Diff | Diff
Patch (1.63 KB, patch)
2011-06-01 11:35 PDT, Annie Sullivan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Annie Sullivan 2011-06-01 10:49:33 PDT 
On GTK, a newline is not inserted when the text is dropped. There needs to be a platform-specific test for this.
Comment 1 Annie Sullivan 2011-06-01 10:51:13 PDT 
Created attachment 95624 [details]
Patch
Comment 2 Ryosuke Niwa 2011-06-01 11:28:56 PDT 
Comment on attachment 95624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review

> LayoutTests/ChangeLog:8
> +        Add platform-specific expected result for GTK, without newline.

You mean without a space?
Comment 3 Annie Sullivan 2011-06-01 11:32:37 PDT 
(In reply to comment #2)
> (From update of attachment 95624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Add platform-specific expected result for GTK, without newline.
> 
> You mean without a space?

Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"?
Comment 4 Ryosuke Niwa 2011-06-01 11:33:16 PDT 
Comment on attachment 95624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review

>>> LayoutTests/ChangeLog:8
>>> +        Add platform-specific expected result for GTK, without newline.
>> 
>> You mean without a space?
> 
> Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"?

I think it's nbsp.
Comment 5 Annie Sullivan 2011-06-01 11:35:03 PDT 
Created attachment 95635 [details]
Patch
Comment 6 Annie Sullivan 2011-06-01 11:35:41 PDT 
(In reply to comment #4)
> (From update of attachment 95624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review
> 
> >>> LayoutTests/ChangeLog:8
> >>> +        Add platform-specific expected result for GTK, without newline.
> >> 
> >> You mean without a space?
> > 
> > Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"?
> 
> I think it's nbsp.

Oh, thanks! ChangeLog updated.
Comment 7 Ryosuke Niwa 2011-06-01 11:52:02 PDT 
I think we should add to GTK's skipped list.  Look at around line 357 of LayoutTests/platform/gtk/Skipped.  There's a list of bugs that are listed under the bug 61661.
Comment 8 Ryosuke Niwa 2011-06-01 12:08:18 PDT 
The test is added to the skipped list in http://trac.webkit.org/changeset/87835.