Bug 61853 – Web Inspector: allow opening inspector for existing workers

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

We need a sidebar pane that would enumerate all running workers and allow to open inspector for each of them.

[Yury Semikhatsky]

Created attachment 95582 [details]
Patch

[WebKit Review Bot]

Comment on attachment 95582 [details]
Patch

Attachment 95582 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8754499

[Yury Semikhatsky]

Created attachment 95585 [details]
Patch

[Pavel Feldman]

Is there a screenshot? I was thinking that workers could be opened via clicking the links, not the checkboxes...

[Pavel Feldman]

Comment on attachment 95585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95585&action=review

Overall looks good. r- for no constants, no screenshots. Btw, how do we test this?

> Source/WebCore/inspector/front-end/WorkerManager.js:77
> +        var win = this._workerIdToWindow[workerId];

please do not use abbreviations. workerWindow?

> Source/WebCore/inspector/front-end/WorkerManager.js:85
> +        url = url.replace("docked=true&", "");

I thought that "docked" was processed in /chromium/ only. Is it not so?

> Source/WebCore/inspector/front-end/WorkersSidebarPane.js:119
> +    workerManager.addEventListener("worker-added", this._workerAdded, this);

These should be constants.

> Source/WebCore/inspector/front-end/WorkersSidebarPane.js:139
> +        workerItem.checkbox.checked = false;

I'd rather have a list of links.

[Yury Semikhatsky]

Created attachment 95598 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 95585 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95585&action=review
> 
> Overall looks good. r- for no constants, no screenshots. Btw, how do we test this?
> 
> > Source/WebCore/inspector/front-end/WorkerManager.js:77
> > +        var win = this._workerIdToWindow[workerId];
> 
> please do not use abbreviations. workerWindow?
> 
Done.

> > Source/WebCore/inspector/front-end/WorkerManager.js:85
> > +        url = url.replace("docked=true&", "");
> 
> I thought that "docked" was processed in /chromium/ only. Is it not so?
> 
Yes, it is. We can add platform-dependent hook here or try to refactor Chromium code to make it mimic other ports behavior.

> > Source/WebCore/inspector/front-end/WorkersSidebarPane.js:119
> > +    workerManager.addEventListener("worker-added", this._workerAdded, this);
> 
> These should be constants.
> 
Done.

> > Source/WebCore/inspector/front-end/WorkersSidebarPane.js:139
> > +        workerItem.checkbox.checked = false;
> 
> I'd rather have a list of links.

I started with a list of links but it doesn't give you an idea on which workers are already being inspected. So I'd leave it as a list of checkboxes for now.

[Yury Semikhatsky]

Committed r87803: <http://trac.webkit.org/changeset/87803>