Bug 61852 - svg/custom/animate-target-id-changed.svg is flaky
Summary: svg/custom/animate-target-id-changed.svg is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 03:50 PDT by Mario Sanchez Prada
Modified: 2012-06-23 07:37 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-06-01 03:50:21 PDT
This test failed today at some point in the GTK 64-bit bot with no related change in the SVN that I could blame:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r87787%20%2822961%29/svg/custom/animate-target-id-changed-pretty-diff.html

After some investigation, it looks to me like it could have happened due to some flakyness in the test itself, since the problem is that the SVG was rendered red instead of green (as per the animation itself), and it occurs to me that it could be due to the usage of timeouts or something like that (just wondering):

<rect id="target" width="100" height="100" fill="red"/>
<animate attributeName="fill" xlink:href="#target" from="green" to="green" dur="0.5" fill="freeze"/>
<script type="text/ecmascript">
<![CDATA[
if (window.layoutTestController) {
    layoutTestController.waitUntilDone();
    setTimeout(function() {
        document.getElementById('target').setAttribute("id", "newId");
        setTimeout(function() { layoutTestController.notifyDone(); }, 0);
   }, 0);
}
]]>

CCing people that might be interested on this (author and reviewer for the commit introducing the test [1])

[1] http://trac.webkit.org/changeset/79569
Comment 1 Mario Sanchez Prada 2011-06-01 05:01:39 PDT
Skipped in the GTK port, as it was observed failing for a couple of times more:

http://trac.webkit.org/changeset/87795
Comment 2 Zan Dobersek 2012-06-23 07:37:49 PDT
The test is consistently passing so its expectation was removed in http://trac.webkit.org/changeset/120476. Closing the bug.