Bug 61846 - [EFL] Add null checking condition to EditorClientEfl.cpp
Summary: [EFL] Add null checking condition to EditorClientEfl.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 01:41 PDT by Gyuyoung Kim
Modified: 2011-06-01 04:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2011-06-01 01:44 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-06-01 01:41:52 PDT 
In EditorClientEfl::handleEditingKeyboardEvent(), it uses caretBrowsingEnabled() of settings(). However, it doesn't check if settings() is null.
settgins() of frame can be null.

Frame.h 
   Settings* settings() const; // can be NULL
Comment 1 Gyuyoung Kim 2011-06-01 01:44:55 PDT 
Created attachment 95566 [details]
Patch
Comment 2 Kent Tamura 2011-06-01 01:52:41 PDT 
Comment on attachment 95566 [details]
Patch

ok
Comment 3 WebKit Commit Bot 2011-06-01 04:41:08 PDT 
Comment on attachment 95566 [details]
Patch

Clearing flags on attachment: 95566

Committed r87794: <http://trac.webkit.org/changeset/87794>
Comment 4 WebKit Commit Bot 2011-06-01 04:41:13 PDT 
All reviewed patches have been landed.  Closing bug.