Bug 61825 - Change the Page Visibility attribute names as per the spec
Summary: Change the Page Visibility attribute names as per the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://dvcs.w3.org/hg/webperf/raw-fil...
Keywords:
Depends on:
Blocks: 60576
  Show dependency tree / graph
 
Reported: 2011-05-31 17:38 PDT by Shishir Agrawal
Modified: 2011-06-01 07:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.94 KB, patch)
2011-05-31 17:43 PDT, Shishir Agrawal 		tonyg: review+
tonyg: commit-queue-
Details | Formatted Diff | Diff
Patch (14.47 KB, patch)
2011-06-01 04:07 PDT, Shishir Agrawal 		no flags Details | Formatted Diff | Diff
Patch (14.50 KB, patch)
2011-06-01 04:22 PDT, Shishir Agrawal 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shishir Agrawal 2011-05-31 17:38:23 PDT 
The recent spec changes ask for two name changes in the Page Visibility Spec:

1. The event needs to be webkitVisibilityChange from webkitVisibilityStateChange
2. The attribute webkitIsVisible needs to change to webkitHidden
Comment 1 Shishir Agrawal 2011-05-31 17:43:03 PDT 
Created attachment 95521 [details]
Patch
Comment 2 Tony Gentilcore 2011-06-01 01:33:01 PDT 
Comment on attachment 95521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95521&action=review

Please update the ChangeLog, everything else looks good.

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=61825

In the bug, you mention:
1. The event needs to be webkitVisibilityChange from webkitVisibilityStateChange
2. The attribute webkitIsVisible needs to change to webkitHidden

That sort of description should always go in the ChangeLog. Also, if available, a link to the spec update would be nice.
Comment 3 Shishir Agrawal 2011-06-01 04:07:00 PDT 
Created attachment 95581 [details]
Patch

Addressing Tony's comments.
Comment 4 Tony Gentilcore 2011-06-01 04:16:42 PDT 
Comment on attachment 95581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95581&action=review

> Source/WebCore/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=61825

Sorry for the extra nit. ChangeLogs should be formatted as:

[1 line description, usually bug title]
[link to bug]

[longer description]

[per file/method descriptions]

If you just swap the bug link and the spec link everything will be good to go.
Comment 5 Shishir Agrawal 2011-06-01 04:22:03 PDT 
Created attachment 95584 [details]
Patch

Addressing Tony's comments.
Comment 6 WebKit Commit Bot 2011-06-01 07:11:35 PDT 
Comment on attachment 95584 [details]
Patch

Clearing flags on attachment: 95584

Committed r87802: <http://trac.webkit.org/changeset/87802>
Comment 7 WebKit Commit Bot 2011-06-01 07:11:41 PDT 
All reviewed patches have been landed.  Closing bug.