Bug 61820 - Transcode test-par-16-9 LayoutTest video to .ogv
Summary: Transcode test-par-16-9 LayoutTest video to .ogv
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-31 16:31 PDT by Scott Franklin
Modified: 2011-06-20 11:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (113.01 KB, patch)
2011-05-31 16:33 PDT, Scott Franklin 		no flags Details | Formatted Diff | Diff
Patch (113.07 KB, patch)
2011-05-31 16:39 PDT, Scott Franklin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Franklin 2011-05-31 16:31:26 PDT 
Transcode test-par-16-9 LayoutTest video to .ogv
Comment 1 Scott Franklin 2011-05-31 16:33:57 PDT 
Created attachment 95507 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-31 16:37:14 PDT 
Attachment 95507 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1

LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Scott Franklin 2011-05-31 16:39:57 PDT 
Created attachment 95509 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-06-02 08:39:27 PDT 
I can never remember who does chrome video stuff... maybe atwilson?
Comment 5 Andrew Wilson 2011-06-02 09:04:35 PDT 
+scherkus
Comment 6 Andrew Scherkus 2011-06-02 10:10:27 PDT 
tiny nit.. the original file included audio

if the transcoded copy also includes audio then it's extension should be .ogg as opposed to .ogv
Comment 7 Andrew Scherkus 2011-06-02 10:25:04 PDT 
hrmm.. ignore my comment

media-file.js expects ogv
Comment 8 Andrew Scherkus 2011-06-03 14:26:34 PDT 
File is good!

Landed by hand due to binary content:
http://trac.webkit.org/changeset/88053
Comment 9 Eric Seidel (no email) 2011-06-18 13:39:26 PDT 
Comment on attachment 95509 [details]
Patch

Cleared review? from attachment 95509 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Comment 10 Andrew Scherkus 2011-06-20 11:50:31 PDT 
Nope we should be good here as I landed the patch by hand due to binary content.

Apologies about not clearing the review? earlier!