Bug 61803 – Web Inspector: [Chromium] DevTools worker scripts are not included into devtool_frontend.zip

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

From http://crbug.com/82614:

Run Chromium against downloaded & unzipped devtools_frontend.zip (using --debug-devtools-frontend flag). It turns out, that worker scripts for text highlighting and heap profiles processing are missing in the archive, resulting in non-working functionality.

[Mikhail Naganov]

Created attachment 95473 [details]
patch

[Mikhail Naganov]

Created attachment 95480 [details]
put all source highlighter files

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/87781:


2011-05-31  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
        https://bugs.webkit.org/show_bug.cgi?id=61803

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py:

[Mikhail Naganov]

The patch was rolled out (https://bugs.webkit.org/show_bug.cgi?id=61842)
The reason is that Chromium bots run Python v2.4 which doesn't have os.path.relpath function yet.

[Mikhail Naganov]

Created attachment 95563 [details]
avoid using os.path.relpath

[Yury Semikhatsky]

Comment on attachment 95563 [details]
avoid using os.path.relpath

View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review

> Source/WebKit/chromium/scripts/generate_devtools_zip.py:74
> +    return ParsedArgs(inspector_html, devtools_files, workers_files,

You can put the whole expression in one line, there is no 80chars limit in WebKit.

[Mikhail Naganov]

(In reply to comment #6)
> (From update of attachment 95563 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review
> 
> > Source/WebKit/chromium/scripts/generate_devtools_zip.py:74
> > +    return ParsedArgs(inspector_html, devtools_files, workers_files,
> 
> You can put the whole expression in one line, there is no 80chars limit in WebKit.

Fixed.

[Mikhail Naganov]

Re-landed as http://trac.webkit.org/changeset/87786.


2011-06-01  Mikhail Naganov  <[e-mail]>

        Reviewed by Yury Semikhatsky.

        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
        https://bugs.webkit.org/show_bug.cgi?id=61803

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py: