Bug 61791 – [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

This is useful to implement the usual "do not close this tab, there are unsubmitted forms" warning in browsers.

[Xan Lopez]

Created attachment 95450 [details]
Patch

[Xan Lopez]

Not much I can do about the style warning, the function has to be in C style since it's public API.

[WebKit Review Bot]

Attachment 95450 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:29:  webkit_dom_html_text_area_element_is_edited is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:36:  webkit_dom_html_input_element_is_edited is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 95450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95450&action=review

>> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:29
>> +gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* area)
> 
> webkit_dom_html_text_area_element_is_edited is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

Why not webkit_dom_html_text_area_element_last_change_was_user_edit?

[Martin Robinson]

(In reply to comment #4)
> (From update of attachment 95450 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95450&action=review
> 
> >> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:29
> >> +gboolean webkit_dom_html_text_area_element_is_edited(WebKitDOMHTMLTextAreaElement* area)
> > 
> > webkit_dom_html_text_area_element_is_edited is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> 
> Why not webkit_dom_html_text_area_element_last_change_was_user_edit?

Probably this name should be changed before landing, by the way. I think webkit_dom_html_text_area_element_is_edited inaccurately portrays what this method does.

[Xan Lopez]

Comment on attachment 95450 [details]
Patch

Clearing flags on attachment: 95450

Committed r87741: <http://trac.webkit.org/changeset/87741>

[Xan Lopez]

All reviewed patches have been landed.  Closing bug.