[Chromium] Update registerProtocolHandler tests for chromium.
Created attachment 95393 [details] Patch
Created attachment 95395 [details] Patch
Comment on attachment 95395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95395&action=review > Source/WebCore/ChangeLog:10 > + Detect syntax errors before security errors. Could you write reasons why we need to detect syntax errors earlier? > Source/WebCore/ChangeLog:15 > +2011-05-30 James Kozianski <koz@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Make isValidProtocol() accept protocols with '+'. > + https://bugs.webkit.org/show_bug.cgi?id=61759 > + > + * page/Navigator.cpp: > + (WebCore::Navigator::registerProtocolHandler): > + Detect syntax errors before security errors. > + * platform/KURLGoogle.cpp: > + (WebCore::isSchemeChar): > + Include '+' in the list of valid characters. > + > +2011-05-30 James Kozianski <koz@chromium.org> Teere are two ChangeLog entries.
Created attachment 95396 [details] Patch
Comment on attachment 95395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95395&action=review >> Source/WebCore/ChangeLog:10 >> + Detect syntax errors before security errors. > > Could you write reasons why we need to detect syntax errors earlier? Done. >> Source/WebCore/ChangeLog:15 >> +2011-05-30 James Kozianski <koz@chromium.org> > > Teere are two ChangeLog entries. Done.
Comment on attachment 95396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95396&action=review > Source/WebCore/ChangeLog:11 > + [Chromium] Make isValidProtocol() accept protocols with '+'. > + > + Also, detect syntax errors before security errors; some syntax errors > + will also trigger a security error, but it's more helpful to the > + programmer to know if they have a syntax error, which are well-defined > + in the spec, rather than a security error, which aren't. > + https://bugs.webkit.org/show_bug.cgi?id=61759 nit: Usually we use the order of <One-line summary> <Bug URL> <Description>
Created attachment 95397 [details] Patch
Comment on attachment 95396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95396&action=review >> Source/WebCore/ChangeLog:11 >> + https://bugs.webkit.org/show_bug.cgi?id=61759 > > nit: Usually we use the order of > <One-line summary> > <Bug URL> > > <Description> Done.
Committed r87713: <http://trac.webkit.org/changeset/87713>