Bug 61751 - Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
Summary: Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-30 15:35 PDT by Joseph Pecoraro
Modified: 2011-05-31 11:54 PDT (History)
10 users (show)

See Also:

[PATCH] Fix Basic Issue (1.23 KB, patch)
2011-05-30 15:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-05-30 15:35:04 PDT
I was seeing the following error:

  TypeError: 'undefined' is not a function (evaluating 'InspectorFrontendHost.saveSessionSetting("debugger-enabled", "true")')
  From calling: InspectorFrontendHost.saveSessionSetting("debugger-enabled", "false");

Looking at the stub + IDL I saw:

  1. in Stub but not IDL: attach, detach, search, canAttachWindow
  2. in IDL but not Stub: requestAttachWindow, requestDetachWindow, saveSessionSetting

This only adds the missing function which was causing visible issues. I think
ideally I can probably remove everything in list (1) and add stubs for everything
in list (2).
Comment 1 Joseph Pecoraro 2011-05-30 15:38:00 PDT
Created attachment 95376 [details]
[PATCH] Fix Basic Issue

I'm a bit behind and need to update, but this fixes the basic issue.
Feel free to r- and demand I look into removing/adding the other functions.
Comment 2 WebKit Commit Bot 2011-05-31 11:54:12 PDT
Comment on attachment 95376 [details]
[PATCH] Fix Basic Issue

Clearing flags on attachment: 95376

Committed r87744: <http://trac.webkit.org/changeset/87744>
Comment 3 WebKit Commit Bot 2011-05-31 11:54:17 PDT
All reviewed patches have been landed.  Closing bug.