Bug 61748 - [efl] Add ewk_util.h to EWebKit.h
Summary: [efl] Add ewk_util.h to EWebKit.h
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-30 14:24 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-06-16 13:21 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.12 KB, patch)
2011-05-30 14:25 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-05-30 14:24:40 PDT 
[efl] Add ewk_util.h to EWebKit.h
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-05-30 14:25:48 PDT 
Created attachment 95372 [details]
Patch
Comment 2 Ryuan Choi 2011-05-30 14:37:18 PDT 
Good.
Does ewk_util_image_from_cairo_surface_add need to have EAPI ?
Comment 3 Gyuyoung Kim 2011-05-30 16:43:21 PDT 
I think the function of ewk_util.h need to have EAPI for visibility.
Comment 4 Leandro Pereira 2011-05-31 09:59:16 PDT 
(In reply to comment #3)
> I think the function of ewk_util.h need to have EAPI for visibility.

EAPI will be added on another patch, that also changes ewk_util.c (by adding a few functions used by DRT).
Comment 5 Lucas De Marchi 2011-05-31 16:18:34 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > I think the function of ewk_util.h need to have EAPI for visibility.
> 
> EAPI will be added on another patch, that also changes ewk_util.c (by adding a few functions used by DRT).

Are you sure this function is EAPI? It seems very odd to me to call it from browser... For me it'd be a candidate to move to ewk_private.h
Comment 6 Raphael Kubo da Costa (:rakuco) 2011-06-10 09:16:37 PDT 
Alright, closing the report -- the other functions which were going to be added to ewk_util ended up being added somewhere else, so there is not much point in exporting the header anymore.
Comment 7 Leandro Pereira 2011-06-16 13:21:05 PDT 
Comment on attachment 95372 [details]
Patch

Clearing the flags.