WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61746
[efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746
Summary
[efl] Add ewk API to enable/disable developer extras.
Raphael Kubo da Costa (:rakuco)
Reported
2011-05-30 14:13:11 PDT
[efl] Add ewk API to enable/disable developer extras.
Attachments
Patch
(4.59 KB, patch)
2011-05-30 14:14 PDT
,
Raphael Kubo da Costa (:rakuco)
no flags
Details
Formatted Diff
Diff
Fixed patch
(4.62 KB, patch)
2011-05-31 09:56 PDT
,
Leandro Pereira
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1
2011-05-30 14:14:53 PDT
Created
attachment 95370
[details]
Patch
Adam Barth
Comment 2
2011-05-30 14:18:24 PDT
Comment on
attachment 95370
[details]
Patch ok
Lucas De Marchi
Comment 3
2011-05-30 14:23:30 PDT
Comment on
attachment 95370
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=95370&action=review
Otherwise, looks good
> Source/WebKit/efl/ewk/ewk_view.cpp:2716 > +Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable) > +{ > + EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); > + EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); > + if (priv->settings.enable_developer_extras != enable) {
Since this is EAPI and Eina_Bool could assume values other than 1 and 0, a protection is needed for the enable argument. See ewk_view_setting_enable_scripts_set() as an example.
Lucas De Marchi
Comment 4
2011-05-30 14:25:44 PDT
(In reply to
comment #2
)
> (From update of
attachment 95370
[details]
) > ok
I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this.
Adam Barth
Comment 5
2011-05-30 14:29:22 PDT
> I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this.
Definitely!
Gyuyoung Kim
Comment 6
2011-05-30 16:46:14 PDT
If Lucas comment is added to this patch, looks good to me.
Leandro Pereira
Comment 7
2011-05-31 09:56:41 PDT
Created
attachment 95447
[details]
Fixed patch
Lucas De Marchi
Comment 8
2011-05-31 16:22:22 PDT
(In reply to
comment #7
)
> Created an attachment (id=95447) [details] > Fixed patch
Adam, now it seems good. Could you rubber stamp it?
WebKit Commit Bot
Comment 9
2011-05-31 18:05:23 PDT
Comment on
attachment 95447
[details]
Fixed patch Clearing flags on attachment: 95447 Committed
r87765
: <
http://trac.webkit.org/changeset/87765
>
WebKit Commit Bot
Comment 10
2011-05-31 18:05:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug