Bug 61739 – [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Caio Marcelo de Oliveira Filho]

[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals

[Caio Marcelo de Oliveira Filho]

Created attachment 95356 [details]
Patch

[Tor Arne Vestbø]

Comment on attachment 95356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95356&action=review

lgtm, a few comments:

> Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:-9
> -    height: 300; width: 600

Don't split this, it just adds to the diff for no reason.

> Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:30
> +                        firstPageOpened = thisPage;

pages.firstPageOpened

[Caio Marcelo de Oliveira Filho]

Created attachment 95461 [details]
fix tor arne comments

[Caio Marcelo de Oliveira Filho]

Created attachment 95479 [details]
same as before

Updated to add Tor Arne as reviewer, and using cq to commit.

[WebKit Commit Bot]

Comment on attachment 95479 [details]
same as before

Rejecting attachment 95479 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8758076

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 95479 [details]:

http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 95479 [details]
same as before

Clearing flags on attachment: 95479

Committed r87796: <http://trac.webkit.org/changeset/87796>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r87796 cherry-picked into qtwebkit-2.2 with commit 52da9d6 <http://gitorious.org/webkit/qtwebkit/commit/52da9d6>