Bug 61725 - [GTK] Implement JavaScript dialogs in MiniBrowser
Summary: [GTK] Implement JavaScript dialogs in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-05-30 03:48 PDT by Carlos Garcia Campos
Modified: 2011-05-30 09:25 PDT (History)
0 users

See Also:

Attachments
Patch (6.13 KB, patch)
2011-05-30 03:53 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-05-30 03:48:15 PDT 
runJavaScriptAlert, runJavaScriptConfirm and runJavaScriptPrompt are currently unimplemented in MiniBrowser.
Comment 1 Carlos Garcia Campos 2011-05-30 03:53:49 PDT 
Created attachment 95332 [details]
Patch
Comment 2 Martin Robinson 2011-05-30 07:22:05 PDT 
Comment on attachment 95332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:191
> +    char *buffer = (char *)g_malloc(length * sizeof(char));

You can omit sizeof(char) here. I'm pretty sure it's always one in C. Please put a space after the cast.

> Tools/MiniBrowser/gtk/BrowserWindow.c:460
> +    WKStringRef retval = (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) ? WKStringCreateWithUTF8CString(gtk_entry_get_text(GTK_ENTRY(entry))) : 0;

-> returnValue
Comment 3 Carlos Garcia Campos 2011-05-30 09:25:25 PDT 
Committed r87690: <http://trac.webkit.org/changeset/87690>