Bug 61723 - NRWT: Exception in verbose printing mode
Summary: NRWT: Exception in verbose printing mode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-05-30 01:37 PDT by Hao Zheng
Modified: 2011-05-31 22:54 PDT (History)
2 users (show)

See Also:

Proposed patch. (1.46 KB, patch)
2011-05-30 01:42 PDT, Hao Zheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hao Zheng 2011-05-30 01:37:25 PDT
File "/usr/local/google/code/webkit.chromium/webkit/Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py", line 351, in print_progress
    self._meter.update("%s (%d%%): %d ran as expected, %d didn't,"
AttributeError: 'NoneType' object has no attribute 'update'

Caused by https://bugs.webkit.org/show_bug.cgi?id=60326
Comment 1 Hao Zheng 2011-05-30 01:42:52 PDT
Created attachment 95330 [details]
Proposed patch.

delegate to self._update
Comment 2 Dirk Pranke 2011-05-31 19:45:16 PDT
Comment on attachment 95330 [details]
Proposed patch.

LGTM. Good catch.
Comment 3 WebKit Commit Bot 2011-05-31 22:53:36 PDT
The commit-queue encountered the following flaky tests while processing attachment 95330 [details]:

http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org)
http/tests/websocket/tests/sub-protocol-with-space.html bug 61434 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-05-31 22:54:52 PDT
Comment on attachment 95330 [details]
Proposed patch.

Clearing flags on attachment: 95330

Committed r87774: <http://trac.webkit.org/changeset/87774>
Comment 5 WebKit Commit Bot 2011-05-31 22:54:57 PDT
All reviewed patches have been landed.  Closing bug.