Bug 61712 - Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
Summary: Embedded Vimeo video, when taken fullscreen, is overlapped by content from th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-29 14:48 PDT by Jer Noble
Modified: 2011-05-29 19:05 PDT (History)
0 users

See Also:

Attachments
Patch (13.88 KB, patch)
2011-05-29 15:09 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (15.90 KB, patch)
2011-05-29 16:57 PDT, Jer Noble 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-05-29 14:48:08 PDT 
Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
Comment 1 Jer Noble 2011-05-29 15:07:29 PDT 
<rdar://problem/9521845>
Comment 2 Jer Noble 2011-05-29 15:09:23 PDT 
Created attachment 95302 [details]
Patch
Comment 3 Simon Fraser (smfr) 2011-05-29 15:22:08 PDT 
Comment on attachment 95302 [details]
Patch

There's nothing here that maintains m_containsFullScreenElement in the face of DOM operations
Comment 4 Jer Noble 2011-05-29 16:57:45 PDT 
Created attachment 95307 [details]
Patch
Comment 5 Simon Fraser (smfr) 2011-05-29 17:08:49 PDT 
Comment on attachment 95307 [details]
Patch

I'm not really a fan of how we touch style in ancestor documents, and I suspect that there's a way to re-parent whole iframes that will escape your bit maintenance. But this seems like an OK approach in the short term. Please test thoroughly.

Please file a new bug to explore alternative ways to fix this, e.g. by doing stuff in RenderLayer.

Oh, and a testcase would be good.
Comment 6 Jer Noble 2011-05-29 19:05:39 PDT 
Committed r87660: <http://trac.webkit.org/changeset/87660>