Race condition in full screen controller, which leads to problem when web process crashes
Created attachment 95295 [details] Patch
Committed r87644: <http://trac.webkit.org/changeset/87644>
The initial patch was too simple-minded and could result in a WKView leak.
Created attachment 95308 [details] Patch
Comment on attachment 95308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424 > + [self release]; // Balanced by retain in exitAcceleratedCompositingMode below. I have corrected this to say “above” locally.
Comment on attachment 95308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:410 > + if (!_isExitingAcceleratedCompositingMode) > + return; This shouldn’t happen. It’s good to be prepared for this, but I suggest asserting that it doesn’t happen, in addition. >> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424 >> + [self release]; // Balanced by retain in exitAcceleratedCompositingMode below. > > I have corrected this to say “above” locally. Please also correct the name of the method the comment is referring to!
Committed r87656: <http://trac.webkit.org/changeset/87656>