Bug 61678 - JS API is too aggressive about throwing exceptions for NULL get or set operations
Summary: JS API is too aggressive about throwing exceptions for NULL get or set operat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-27 17:16 PDT by Geoffrey Garen
Modified: 2011-05-27 17:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.27 KB, patch)
2011-05-27 17:19 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-05-27 17:16:40 PDT 
JS API is too aggressive about throwing exceptions for NULL get or set operations
Comment 1 Geoffrey Garen 2011-05-27 17:19:50 PDT 
Created attachment 95233 [details]
Patch
Comment 2 Geoffrey Garen 2011-05-27 17:20:25 PDT 
<rdar://problem/9518965>
Comment 3 WebKit Review Bot 2011-05-27 17:22:48 PDT 
Attachment 95233 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1

Source/JavaScriptCore/API/tests/testapi.c:314:  MyObject_set_nullGetForwardSet is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2011-05-27 17:29:00 PDT 
Committed r87588: <http://trac.webkit.org/changeset/87588>