Bug 61677 - Property caching is too aggressive for API objects
Summary: Property caching is too aggressive for API objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-27 16:38 PDT by Geoffrey Garen
Modified: 2011-05-27 16:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.59 KB, patch)
2011-05-27 16:41 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (12.44 KB, patch)
2011-05-27 16:50 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-05-27 16:38:34 PDT 
Property caching is too aggressive for API objects
Comment 1 Geoffrey Garen 2011-05-27 16:41:07 PDT 
Created attachment 95227 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-27 16:43:14 PDT 
Attachment 95227 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1

Source/JavaScriptCore/runtime/JSTypeInfo.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/API/tests/testapi.c:358:  PropertyCatchalls_getProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:395:  PropertyCatchalls_setProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:415:  PropertyCatchalls_getPropertyNames is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:429:  PropertyCatchalls_definition is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:452:  PropertyCatchalls_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 6 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-05-27 16:50:06 PDT 
Created attachment 95228 [details]
Patch
Comment 4 WebKit Review Bot 2011-05-27 16:52:10 PDT 
Attachment 95228 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1

Source/JavaScriptCore/runtime/JSTypeInfo.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/API/tests/testapi.c:358:  PropertyCatchalls_getProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:395:  PropertyCatchalls_setProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:415:  PropertyCatchalls_getPropertyNames is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:429:  PropertyCatchalls_definition is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/API/tests/testapi.c:452:  PropertyCatchalls_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 6 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2011-05-27 16:53:32 PDT 
<rdar://problem/9518788>
Comment 6 Geoffrey Garen 2011-05-27 16:53:40 PDT 
Committed r87586: <http://trac.webkit.org/changeset/87586>