Bug 61666 - Simplify flow of CachedResourceRequest creation
Summary: Simplify flow of CachedResourceRequest creation
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
Depends on:
Reported: 2011-05-27 14:18 PDT by Nate Chapin
Modified: 2011-05-30 00:46 PDT (History)
4 users (show)

See Also:

patch (5.55 KB, patch)
2011-05-27 14:23 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2011-05-27 14:18:38 PDT
The creation of a CachedResourceRequest seems really circular.  CachedResourceLoader calls CachedResource::load(), which then calls back to CachedResourceLoader::load(), which finally calls CachedResourceRequest::load().

I'm going to upload a patch and let others decide whether it's actually prettier than what we have now.
Comment 1 Nate Chapin 2011-05-27 14:23:04 PDT
Created attachment 95215 [details]
Comment 2 Adam Barth 2011-05-27 14:34:43 PDT
Comment on attachment 95215 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=95215&action=review

> Source/WebCore/loader/cache/CachedFont.cpp:-100
> -        dl->load(this, false);

We shouldn't call CachedResourceLoader "dl".  That's an echo of the horrible "DocLoader" name.
Comment 3 Antti Koivisto 2011-05-30 00:18:10 PDT
Comment on attachment 95215 [details]

it's better, r=me
Comment 4 WebKit Commit Bot 2011-05-30 00:45:55 PDT
Comment on attachment 95215 [details]

Clearing flags on attachment: 95215

Committed r87679: <http://trac.webkit.org/changeset/87679>
Comment 5 WebKit Commit Bot 2011-05-30 00:46:01 PDT
All reviewed patches have been landed.  Closing bug.