Bug 61665 - TestFailures page should link to existing bugs when possible
Summary: TestFailures page should link to existing bugs when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 14:05 PDT by Adam Roben (:aroben)
Modified: 2011-06-22 14:11 PDT (History)
3 users (show)

See Also:


Attachments
Add links to existing bugs related to failing tests on TestFailures page (17.04 KB, patch)
2011-06-22 10:01 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Screenshot of the new layout (97.08 KB, image/png)
2011-06-22 10:01 PDT, Adam Roben (:aroben)
no flags Details
Add links to existing bugs related to failing tests on TestFailures page (17.15 KB, patch)
2011-06-22 10:10 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-27 14:05:18 PDT
The TestFailures page contains links to help file a new bug about tests that are failing. If a bug already exists for the failures, this is just encouraging people to file duplicates.

It would be a lot better if the TestFailures page could link to existing bugs when they exist instead of showing the new bug link.
Comment 1 Adam Roben (:aroben) 2011-05-27 14:06:20 PDT
The tricky thing is identifying the existing bugs. Ryosuke pointed out that we could use test_expectations.txt files for bots that use them. (Of course, right now I don't think the TestFailures page shows information for any such bots.)
Comment 2 Adam Roben (:aroben) 2011-06-22 08:33:45 PDT
At a bare minimum we could just show the links to existing bugs alongside the new bug link. That way the user could determine if there is already an appropriate bug filed, rather than TestFailures trying to figure that out for you.
Comment 3 Adam Roben (:aroben) 2011-06-22 09:36:43 PDT
Let's use this bug to cover showing the existing bugs. We can file a separate bug to remove the new bug link when we detect it isn't needed, if we decide that would be desirable.
Comment 4 Adam Roben (:aroben) 2011-06-22 10:01:10 PDT
Created attachment 98190 [details]
Add links to existing bugs related to failing tests on TestFailures page
Comment 5 Adam Roben (:aroben) 2011-06-22 10:01:29 PDT
Created attachment 98191 [details]
Screenshot of the new layout
Comment 6 Adam Roben (:aroben) 2011-06-22 10:10:48 PDT
Created attachment 98194 [details]
Add links to existing bugs related to failing tests on TestFailures page
Comment 7 Ryosuke Niwa 2011-06-22 10:12:02 PDT
Comment on attachment 98190 [details]
Add links to existing bugs related to failing tests on TestFailures page

View in context: https://bugs.webkit.org/attachment.cgi?id=98190&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:54
> +function addParametersToURL(url, queryParameters) {

I'm not sure if parameter is a good name since it's usually called query part of the URL.  Maybe addQueryToURL or addQueryPartToURL?
Comment 8 Adam Roben (:aroben) 2011-06-22 10:17:18 PDT
Comment on attachment 98190 [details]
Add links to existing bugs related to failing tests on TestFailures page

View in context: https://bugs.webkit.org/attachment.cgi?id=98190&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:54
>> +function addParametersToURL(url, queryParameters) {
> 
> I'm not sure if parameter is a good name since it's usually called query part of the URL.  Maybe addQueryToURL or addQueryPartToURL?

How about addQueryParametersToURL? That's what my fingers kept wanting to type anyway.
Comment 9 Ryosuke Niwa 2011-06-22 10:17:49 PDT
(In reply to comment #8)
> (From update of attachment 98190 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98190&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:54
> >> +function addParametersToURL(url, queryParameters) {
> > 
> > I'm not sure if parameter is a good name since it's usually called query part of the URL.  Maybe addQueryToURL or addQueryPartToURL?
> 
> How about addQueryParametersToURL? That's what my fingers kept wanting to type anyway.

SGTM.
Comment 10 Adam Roben (:aroben) 2011-06-22 10:28:58 PDT
Updated build.webkit.org

Committed r89447: <http://trac.webkit.org/changeset/89447>
Comment 11 Joseph Pecoraro 2011-06-22 10:52:10 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=98190&action=review

I know this landed, but I had a tab open with this comment. Not important or
worthy of a separate commit.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:56
> +        return key + '=' + encodeURIComponent(queryParameters[key])

Nit (style): normally you use semicolons.
Comment 12 Adam Roben (:aroben) 2011-06-22 10:59:04 PDT
(In reply to comment #11)
> View in context: https://bugs.webkit.org/attachment.cgi?id=98190&action=review
> 
> I know this landed, but I had a tab open with this comment. Not important or
> worthy of a separate commit.
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:56
> > +        return key + '=' + encodeURIComponent(queryParameters[key])
> 
> Nit (style): normally you use semicolons.

Whoops! Will fix.
Comment 13 Adam Roben (:aroben) 2011-06-22 14:08:05 PDT
Whoops, this isn't working due to cross-site XHR restrictions :-(
Comment 14 Adam Roben (:aroben) 2011-06-22 14:11:19 PDT
Bill Siegrist is going to add some Access-Control headers to bugs.webkit.org to allow the XHRs to go through. Thanks, Bill!