Bug 61654 - [chromium] Fix crash from empty reflections with masks
Summary: [chromium] Fix crash from empty reflections with masks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 11:51 PDT by Adrienne Walker
Modified: 2011-05-31 16:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2011-05-27 11:54 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2011-05-27 13:18 PDT, Adrienne Walker 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-05-27 11:51:58 PDT 
[chromium] Fix crash from empty reflections with masks
Comment 1 Adrienne Walker 2011-05-27 11:54:17 PDT 
Created attachment 95202 [details]
Patch
Comment 2 James Robinson 2011-05-27 12:41:48 PDT 
Comment on attachment 95202 [details]
Patch

Test should be dumpAsText(), the render tree + pixel output are useless.  Add some text indicating something like 'test passes if it does not crash' so it's clearer what the test is trying to verify.

Can the box-reflect be simplified at all to just show the part needed to hit the crash?
Comment 3 Adrienne Walker 2011-05-27 12:52:47 PDT 
(In reply to comment #2)
> (From update of attachment 95202 [details])
> Test should be dumpAsText(), the render tree + pixel output are useless.  Add some text indicating something like 'test passes if it does not crash' so it's clearer what the test is trying to verify.

Ok.  We had no tests with empty reflections, so I figured it might make sense to see that what was rendered was expected.  It's not that important--I can make it dumpAsText.

> Can the box-reflect be simplified at all to just show the part needed to hit the crash?

I'll see what I can do.
Comment 4 Adrienne Walker 2011-05-27 13:18:08 PDT 
Created attachment 95208 [details]
Patch
Comment 5 James Robinson 2011-05-31 13:35:47 PDT 
Comment on attachment 95208 [details]
Patch

r=me
Comment 6 Adrienne Walker 2011-05-31 16:49:32 PDT 
Committed r87762: <http://trac.webkit.org/changeset/87762>