Bug 61648 - Remove extra args from scroll functions
Summary: Remove extra args from scroll functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 10:51 PDT by Peter Kasting
Modified: 2011-06-06 12:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (14.97 KB, patch)
2011-06-02 14:58 PDT, Peter Kasting 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (15.75 KB, patch)
2011-06-02 17:26 PDT, Peter Kasting 		no flags Details | Formatted Diff | Diff
Patch v3 (15.75 KB, patch)
2011-06-03 11:04 PDT, Peter Kasting 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2011-05-27 10:51:42 PDT 
RenderLayer::scrollRectToVisible() and RenderBox::canBeProgrammaticallyScrolled() both have unused boolean arguments.  I can remove them.

(This bug split off from bug 47036.)
Comment 1 Peter Kasting 2011-06-02 14:58:39 PDT 
Created attachment 95816 [details]
Patch v1
Comment 2 WebKit Review Bot 2011-06-02 15:14:59 PDT 
Comment on attachment 95816 [details]
Patch v1

Attachment 95816 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8760238
Comment 3 Gustavo Noronha (kov) 2011-06-02 16:57:36 PDT 
Comment on attachment 95816 [details]
Patch v1

Attachment 95816 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8755950
Comment 4 WebKit Review Bot 2011-06-02 17:09:11 PDT 
Comment on attachment 95816 [details]
Patch v1

Attachment 95816 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8757572
Comment 5 Peter Kasting 2011-06-02 17:26:27 PDT 
Created attachment 95839 [details]
Patch v2
Comment 6 Antonio Gomes 2011-06-02 19:03:13 PDT 
Comment on attachment 95839 [details]
Patch v2

does it apply to trunk, so we can exersise the buildbots?
Comment 7 Peter Kasting 2011-06-03 11:04:53 PDT 
Created attachment 95927 [details]
Patch v3
Comment 8 Antonio Gomes 2011-06-03 11:12:51 PDT 
Comment on attachment 95927 [details]
Patch v3

r=me as long as bots are happy. Nice clean up!
Comment 9 WebKit Review Bot 2011-06-06 12:21:44 PDT 
Comment on attachment 95927 [details]
Patch v3

Clearing flags on attachment: 95927

Committed r88178: <http://trac.webkit.org/changeset/88178>
Comment 10 WebKit Review Bot 2011-06-06 12:21:49 PDT 
All reviewed patches have been landed.  Closing bug.