Bug 61632 - [GTK] Use alloca() if available for control messages in ConnectionUnix
Summary: [GTK] Use alloca() if available for control messages in ConnectionUnix
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-05-27 07:39 PDT by Carlos Garcia Campos
Modified: 2017-03-11 10:47 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.76 KB, patch)
2011-05-27 07:43 PDT, Carlos Garcia Campos 		mrobinson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-05-27 07:39:38 PDT 
It avoids some heap allocations for the message control buffer when sending and receiving messages.
Comment 1 Carlos Garcia Campos 2011-05-27 07:43:41 PDT 
Created attachment 95172 [details]
Patch
Comment 2 Martin Robinson 2011-07-11 08:50:50 PDT 
Comment on attachment 95172 [details]
Patch

While I admit that this may have some performance benefit, I don't think we should add it until we know what sort of performance benefit. Also I have concerns about using alloca with large data structures.