Bug 61627 – [GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Once bug #61287 (and #61538 for platforms where SOCK_SEQPACKET is not available) is fixed and processes are correctly notified when the other ends closes the connection we don't need Connection::setShouldCloseConnectionOnProcessTermination() anymore.

[Carlos Garcia Campos]

Created attachment 95164 [details]
Patch

This patch depends on bug #61287.

[Carlos Garcia Campos]

Remove dependency on bug #61287, since we finally moved to stream sockets in GTK port. We can now remove Connection::setShouldCloseConnectionOnProcessTermination().

[Martin Robinson]

Comment on attachment 95164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95164&action=review

Great. :)

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:65
> +    int socket = GPOINTER_TO_INT(userData);
> +    close(socket);

This can be one line here.

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:96
> +    // Monitor the child process, it calls waitpid to avoid the child process to become a zombie,

avoid the child process to become a zombie -> prevent the child process from becomming a zombie

[Carlos Garcia Campos]

Committed r89433: <http://trac.webkit.org/changeset/89433>