Bug 61617 - Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
Summary: Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 34564
  Show dependency treegraph
 
Reported: 2011-05-27 01:31 PDT by Ryosuke Niwa
Modified: 2011-05-27 04:39 PDT (History)
6 users (show)

See Also:


Attachments
converts the tests (65.80 KB, patch)
2011-05-27 01:35 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
fixed this this (66.90 KB, patch)
2011-05-27 01:54 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-27 01:31:42 PDT
The following tests should be converted to dumpAsText tests to that the outputs can easily be understood.
editing/pasteboard/smart-paste-001.html
editing/pasteboard/smart-paste-002.html
editing/pasteboard/smart-paste-003.html
Comment 1 Ryosuke Niwa 2011-05-27 01:35:25 PDT
Created attachment 95141 [details]
converts the tests
Comment 2 Kent Tamura 2011-05-27 01:40:28 PDT
Comment on attachment 95141 [details]
converts the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=95141&action=review

> LayoutTests/editing/pasteboard/smart-paste-001-expected.txt:14
> +A space should be added between the preexisting word and the word that's pasted. It should like this this: 

Extra 'this'?

> LayoutTests/editing/pasteboard/smart-paste-002-expected.txt:17
> +A space should be added after the pasted word before the preexising word. It should like this this: 

ditto.

> LayoutTests/editing/pasteboard/smart-paste-003-expected.txt:16
> +A space should be added between the preexisting word and the word that's pasted. No space should be added after the pasted word. It should like this this: 

ditto.
Comment 3 Ryosuke Niwa 2011-05-27 01:48:09 PDT
Comment on attachment 95141 [details]
converts the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=95141&action=review

>> LayoutTests/editing/pasteboard/smart-paste-001-expected.txt:14
>> +A space should be added between the preexisting word and the word that's pasted. It should like this this: 
> 
> Extra 'this'?

This is coming from the original test but I'll fix in a minute.
Comment 4 Ryosuke Niwa 2011-05-27 01:54:44 PDT
Created attachment 95145 [details]
fixed this this
Comment 5 WebKit Commit Bot 2011-05-27 04:39:03 PDT
Comment on attachment 95145 [details]
fixed this this

Clearing flags on attachment: 95145

Committed r87495: <http://trac.webkit.org/changeset/87495>
Comment 6 WebKit Commit Bot 2011-05-27 04:39:08 PDT
All reviewed patches have been landed.  Closing bug.