Bug 61602 - editing/pasteboard/5027857.html should be renamed and converted to a dump-as-markup test
Summary: editing/pasteboard/5027857.html should be renamed and converted to a dump-as-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 34564
  Show dependency tree / graph
 
Reported: 2011-05-26 21:37 PDT by Ryosuke Niwa
Modified: 2011-05-26 22:27 PDT (History)
4 users (show)

See Also:

Attachments
converts the test (12.42 KB, patch)
2011-05-26 21:42 PDT, Ryosuke Niwa 		eric: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (1.24 MB, application/zip)
2011-05-26 22:10 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-26 21:37:35 PDT 
We should give editing/pasteboard/5027857.html a more descriptive name and convert it to a dump-as-markup test.
Comment 1 Ryosuke Niwa 2011-05-26 21:42:58 PDT 
Created attachment 95107 [details]
converts the test
Comment 2 Ryosuke Niwa 2011-05-26 21:43:25 PDT 
It turns out this test produces a horrible markup :(
Comment 3 Eric Seidel (no email) 2011-05-26 21:49:04 PDT 
Comment on attachment 95107 [details]
converts the test

View in context: https://bugs.webkit.org/attachment.cgi?id=95107&action=review

Are you sure you wanted to move this out of quirks mode?

> LayoutTests/editing/pasteboard/paste-code-in-pre.html:16
> +Markup.description(document.getElementsByTagName('p')[0].textContent);

Kinda funny way to do this.
Comment 4 Ryosuke Niwa 2011-05-26 21:50:55 PDT 
(In reply to comment #3)
> (From update of attachment 95107 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95107&action=review
> 
> Are you sure you wanted to move this out of quirks mode?

Yeah, I don't think quirks mode is anything to do with this test.
Comment 5 WebKit Review Bot 2011-05-26 22:10:42 PDT 
Comment on attachment 95107 [details]
converts the test

Attachment 95107 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8740315

New failing tests:
editing/pasteboard/paste-code-in-pre.html
Comment 6 WebKit Review Bot 2011-05-26 22:10:46 PDT 
Created attachment 95111 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Ryosuke Niwa 2011-05-26 22:27:56 PDT 
Committed r87468: <http://trac.webkit.org/changeset/87468>