Bug 61595 - editing/pasteboard/4700297.html should be renamed and converted to a dump-as-markup test
Summary: editing/pasteboard/4700297.html should be renamed and converted to a dump-as-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 34564
  Show dependency treegraph
 
Reported: 2011-05-26 19:41 PDT by Ryosuke Niwa
Modified: 2011-05-26 22:33 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.24 KB, patch)
2011-05-26 19:53 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
new patch (15.35 KB, patch)
2011-05-26 20:14 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-26 19:41:23 PDT
We should give editing/pasteboard/4700297.html a more descriptive name and convert it to a dump-as-markup test.
Comment 1 Ryosuke Niwa 2011-05-26 19:53:34 PDT
Created attachment 95098 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-26 19:55:12 PDT
Comment on attachment 95098 [details]
Patch

I take it we don't need quite as many editing callbacks?
Comment 3 Ryosuke Niwa 2011-05-26 20:00:07 PDT
(In reply to comment #2)
> (From update of attachment 95098 [details])
> I take it we don't need quite as many editing callbacks?

Oops, that's because I put dumpEditingCallbacks in the wrong place :(  Will fix.
Comment 4 Ryosuke Niwa 2011-05-26 20:14:34 PDT
Created attachment 95101 [details]
new patch
Comment 5 Eric Seidel (no email) 2011-05-26 20:17:55 PDT
Comment on attachment 95101 [details]
new patch

OK.
Comment 6 Ryosuke Niwa 2011-05-26 22:33:53 PDT
Comment on attachment 95101 [details]
new patch

Clearing flags on attachment: 95101

Committed r87472: <http://trac.webkit.org/changeset/87472>
Comment 7 Ryosuke Niwa 2011-05-26 22:33:57 PDT
All reviewed patches have been landed.  Closing bug.