Bug 61589 - Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
Summary: Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 18:47 PDT by Luke Macpherson
Modified: 2011-05-26 23:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2011-05-26 18:51 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-05-26 18:47:59 PDT 
Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
Comment 1 Luke Macpherson 2011-05-26 18:51:53 PDT 
Created attachment 95091 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-26 19:34:56 PDT 
Comment on attachment 95091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review

OK.

> Source/WebCore/css/CSSStyleSelector.cpp:-4976
> -            m_style->setMarginBeforeCollapse(MCOLLAPSE);
> -            m_style->setMarginAfterCollapse(MCOLLAPSE);

I assume initial* correctly returns these values?
Comment 3 Luke Macpherson 2011-05-26 20:35:44 PDT 
Comment on attachment 95091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review

>> Source/WebCore/css/CSSStyleSelector.cpp:-4976
>> -            m_style->setMarginAfterCollapse(MCOLLAPSE);
> 
> I assume initial* correctly returns these values?

That is correct. These should have been calling RenderStyle::initialMarginBeforeCollapse/AfterCollapse, which return MCOLLAPSE.
Comment 4 Eric Seidel (no email) 2011-05-26 21:08:08 PDT 
Comment on attachment 95091 [details]
Patch

I can't remember if you're a committer yet or not, but I'll set the cq+ just in case. :)
Comment 5 WebKit Commit Bot 2011-05-26 23:27:11 PDT 
Comment on attachment 95091 [details]
Patch

Clearing flags on attachment: 95091

Committed r87474: <http://trac.webkit.org/changeset/87474>
Comment 6 WebKit Commit Bot 2011-05-26 23:27:16 PDT 
All reviewed patches have been landed.  Closing bug.