Bug 61559 - Transition to full screen video animates in wrong location when scrolled
Summary: Transition to full screen video animates in wrong location when scrolled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-26 14:14 PDT by Jon Lee
Modified: 2011-05-26 17:29 PDT (History)
0 users

See Also:

Attachments
Patch (12.39 KB, patch)
2011-05-26 15:02 PDT, Jon Lee 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2011-05-26 14:14:48 PDT 
<rdar://problem/9496054>
Comment 1 Jon Lee 2011-05-26 15:02:29 PDT 
Created attachment 95050 [details]
Patch
Comment 2 Darin Adler 2011-05-26 16:54:23 PDT 
Comment on attachment 95050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56
> +    void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener);

Should these arguments be const CATransform3D& instead of passing by value?
Comment 3 Jon Lee 2011-05-26 17:27:24 PDT 
(In reply to comment #2)
> (From update of attachment 95050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review
> 
> > Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56
> > +    void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener);
> 
> Should these arguments be const CATransform3D& instead of passing by value?

Good suggestion. Taken.
Comment 4 Jon Lee 2011-05-26 17:29:57 PDT 
Committed r87456: <http://trac.webkit.org/changeset/87456>