Bug 61555 – Chromium doesn't implement WebCore::MediaPlayer::mediaTimeForTimeValue()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Aaron Colwell]

This is a placeholder bug for Chromium Issue 61166(http://code.google.com/p/chromium/issues/detail?id=61166)
I'll upload a patch for the Chromium implementation of WebCore::MediaPlayer::mediaTimeForTimeValue() shortly.

[Aaron Colwell]

Created attachment 95033 [details]
Patch

[Aaron Colwell]

Here is the Chromium side of this patch if you're interested.
http://codereview.chromium.org/7074018/

[WebKit Review Bot]

Comment on attachment 95033 [details]
Patch

Attachment 95033 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8736357

[Aaron Colwell]

Created attachment 95046 [details]
Patch

[WebKit Review Bot]

Comment on attachment 95046 [details]
Patch

Attachment 95046 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8734871

[Aaron Colwell]

Created attachment 95200 [details]
Patch

[WebKit Review Bot]

Comment on attachment 95200 [details]
Patch

Attachment 95200 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8740470

[Aaron Colwell]

Created attachment 95483 [details]
Patch

[WebKit Review Bot]

Comment on attachment 95483 [details]
Patch

Attachment 95483 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8751770

[Aaron Colwell]

Created attachment 95501 [details]
DEPS Patch

[Aaron Colwell]

Created attachment 95618 [details]
mediaTimeForTimeValue() Patch.

[WebKit Review Bot]

Comment on attachment 95618 [details]
mediaTimeForTimeValue() Patch.

Attachment 95618 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8751981

[Aaron Colwell]

Ping. Could someone please review these 2 patches. Thanks.

[David Levin]

Comment on attachment 95618 [details]
mediaTimeForTimeValue() Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=95618&action=review

> Source/WebKit/chromium/public/WebMediaPlayer.h:138
> +    virtual float mediaTimeForTimeValue(float timeValue) const = 0;

How about mediaTimeFromTimeValue?
"For" sounds odd.

[Aaron Colwell]

(In reply to comment #14)
> (From update of attachment 95618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95618&action=review
> 
> > Source/WebKit/chromium/public/WebMediaPlayer.h:138
> > +    virtual float mediaTimeForTimeValue(float timeValue) const = 0;
> 
> How about mediaTimeFromTimeValue?
> "For" sounds odd.

I was just copying the method name from Source/WebCore/platform/graphics/MediaPlayerPrivate.h . Is it worth changing the method name at this middle layer or do you want me to change it all the way up and down the stack?

[WebKit Commit Bot]

Comment on attachment 95501 [details]
DEPS Patch

Clearing flags on attachment: 95501

Committed r87944: <http://trac.webkit.org/changeset/87944>

[WebKit Commit Bot]

Comment on attachment 95618 [details]
mediaTimeForTimeValue() Patch.

Clearing flags on attachment: 95618

Committed r87965: <http://trac.webkit.org/changeset/87965>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 95618 [details]:

http/tests/websocket/tests/frame-length-overflow.html bug 61507 (author: [e-mail])
The commit-queue is continuing to process your patch.