RESOLVED FIXED 61545
[chromium] Be robust to empty viewports in the compositor 
https://bugs.webkit.org/show_bug.cgi?id=61545
Summary [chromium] Be robust to empty viewports in the compositor
Adrienne Walker
Reported 2011-05-26 11:01:19 PDT
[chromium] Be robust to empty viewports in the compositor
Attachments
Patch (4.05 KB, patch)
2011-05-26 11:13 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-05-26 11:13:10 PDT
Created attachment 95008 [details] Patch
Adrienne Walker
Comment 2 2011-05-26 11:17:03 PDT
See: http://code.google.com/p/chromium/issues/detail?id=83961 The order of events that causes this is that the layer renderer is created and a doComposite event is called while the layer renderer (and the main frame) have an empty viewport rect. This might be able to be fixed at a higher level too, but I think this code should be robust to the possibility of an empty content rect.
James Robinson
Comment 3 2011-05-26 11:26:38 PDT
Comment on attachment 95008 [details] Patch R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch?
Adrienne Walker
Comment 4 2011-05-26 11:29:07 PDT
(In reply to comment #3) > (From update of attachment 95008 [details]) > R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch? Thanks. I'll clean that up before landing.
Adrienne Walker
Comment 5 2011-05-26 12:06:58 PDT
Committed r87409: <http://trac.webkit.org/changeset/87409>
Note You need to log in before you can comment on or make changes to this bug.