Bug 61542 - Add a ResourceRequestBase::TargetType for XMLHttpRequests
Summary: Add a ResourceRequestBase::TargetType for XMLHttpRequests
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 10:14 PDT by Vsevolod Vlasov
Modified: 2011-08-02 12:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2011-05-26 10:18 PDT, Vsevolod Vlasov 		ap: review-
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-05-26 10:14:57 PDT 
Add a ResourceRequestBase::TargetType for XMLHttpRequests.

This is needed by inspector to distinguish XHR network callbacks early.
Comment 1 Vsevolod Vlasov 2011-05-26 10:18:23 PDT 
Created attachment 94999 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-05-26 14:21:06 PDT 
Comment on attachment 94999 [details]
Patch

TargetType is going away from ResourceRequestBase, see bug 48483. Some other solution will be needed for Web Inspector.
Comment 3 Alexey Proskuryakov 2011-05-26 14:33:46 PDT 
(I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.)
Comment 4 Vsevolod Vlasov 2011-05-26 15:46:02 PDT 
(In reply to comment #3)
> (I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.)

No, inspector does not use it yet. 
This bug could be closed then.
Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore?
Comment 5 Alexey Proskuryakov 2011-05-26 16:03:07 PDT 
> Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore?

Yes! I've previously added a comment to the header, but it turned out to be insufficiently clear or noticeable.

        // FIXME: This should be moved out of ResourceRequestBase, <https://bugs.webkit.org/show_bug.cgi?id=48483>.
Comment 6 Alexey Proskuryakov 2011-08-02 12:06:29 PDT 
*** Bug 65544 has been marked as a duplicate of this bug. ***