RESOLVED WONTFIX61542
Add a ResourceRequestBase::TargetType for XMLHttpRequests 
https://bugs.webkit.org/show_bug.cgi?id=61542
Summary Add a ResourceRequestBase::TargetType for XMLHttpRequests
Vsevolod Vlasov
Reported 2011-05-26 10:14:57 PDT
Add a ResourceRequestBase::TargetType for XMLHttpRequests. This is needed by inspector to distinguish XHR network callbacks early.
Attachments
Patch (2.09 KB, patch)
2011-05-26 10:18 PDT, Vsevolod Vlasov 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-05-26 10:18:23 PDT
Created attachment 94999 [details] Patch
Alexey Proskuryakov
Comment 2 2011-05-26 14:21:06 PDT
Comment on attachment 94999 [details] Patch TargetType is going away from ResourceRequestBase, see bug 48483. Some other solution will be needed for Web Inspector.
Alexey Proskuryakov
Comment 3 2011-05-26 14:33:46 PDT
(I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.)
Vsevolod Vlasov
Comment 4 2011-05-26 15:46:02 PDT
(In reply to comment #3) > (I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.) No, inspector does not use it yet. This bug could be closed then. Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore?
Alexey Proskuryakov
Comment 5 2011-05-26 16:03:07 PDT
> Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore? Yes! I've previously added a comment to the header, but it turned out to be insufficiently clear or noticeable. // FIXME: This should be moved out of ResourceRequestBase, <https://bugs.webkit.org/show_bug.cgi?id=48483>.
Alexey Proskuryakov
Comment 6 2011-08-02 12:06:29 PDT
*** Bug 65544 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.