Deployment catches a few uninitialized variables in your recent patch: /Users/justin/Labyrinth/WebKit/WebCoreSupport.subproj/WebTextRenderer.m: In function 'createATSULayoutParameters': /Users/justin/Labyrinth/WebKit/WebCoreSupport.subproj/WebTextRenderer.m:1314: warning: 'firstSmallCap' may be used uninitialized in this function /Users/justin/Labyrinth/WebKit/WebCoreSupport.subproj/WebTextRenderer.m:1292: warning: 'substituteRenderer' may be used uninitialized in this function I couldn't figure out why firstSmallCap was uninitialized: UniCharArrayOffset firstSmallCap; if (i == substituteOffset || i == substituteOffset + substituteLength) { if (isSmallCap) { isSmallCap = false; initializeATSUStyle(getSmallCapsRenderer(r)); ATSUSetRunStyle(layout, getSmallCapsRenderer(r)->_ATSUStyle, firstSmallCap, i - firstSmallCap); } firstSmallCap is an argument to ATSUSetRunStyle, not as a ref or anything, but as a value. Initializing it to 0 made one of the layout tests you added fail.
Created attachment 5169 [details] Build fix Sorry about the bug! Darin actually warned me about uninitialized variable warnings in another part of that patch, but I didn't know that I have to test a deployment build. These initial values are never used: firstSmallCap is only used when isSmallCap is true, and whenever isSmallCap is set to true, firstSmallCap is set; substituteRenderer is only used if substituteLength > 0, in which case substituteRenderer is set.
Comment on attachment 5169 [details] Build fix r=me
Created attachment 5189 [details] fix more uninitialized variable warnings These are the ones Darin warned me about. Why do they generate warnings only in deployment configuration?
Apparently gcc warns about uninitialized variables when any sort of optimizations are turned on. Tim H. is looking into a way to turn these warnings on in Development mode w/o enabling optimizations.
Comment on attachment 5189 [details] fix more uninitialized variable warnings r=me