We don't want TimelinePanel._addRecordToTimeline to have any side effects on the source event data, as the data may be dispatched further (e.g. to extensions, see bug 61098).
Created attachment 94974 [details] patch
Comment on attachment 94974 [details] patch lgtm
Comment on attachment 94974 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=94974&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:359 > + } ; is missing. > Source/WebCore/inspector/front-end/TimelinePanel.js:360 > + children = record.children.slice(1).concat(record.children); This line is somewhat different from what it used to be. > Source/WebCore/inspector/front-end/TimelinePanel.js:1027 > + _getRecordDetails: function(sendRequestRecords) The parameter is unused, please remove it here and in _refreshDetails
Created attachment 94983 [details] patch - fixed children flattening for function calls - removed unused parameter from _refreshDetails/_getRecordDetauls()
Comment on attachment 94983 [details] patch Attachment 94983 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8733982 New failing tests: inspector/timeline/timeline-network-resource.html
Created attachment 94988 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
A variation of patch committed manually as r87395: http://trac.webkit.org/changeset/87395 (fixed script name/line for non-timer events, rebaselined custom test expectation for chromium/linux)