Bug 61512 - WebKit2 bundle missing localization subdirectories
Summary: WebKit2 bundle missing localization subdirectories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 01:53 PDT by Steve Falkenburg
Modified: 2011-05-26 10:05 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2011-05-26 01:55 PDT, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2011-05-26 02:16 PDT, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2011-05-26 10:01 PDT, Steve Falkenburg
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-05-26 01:53:55 PDT
WebKit2 bundle missing localization subdirectories
Comment 1 Steve Falkenburg 2011-05-26 01:55:09 PDT
Created attachment 94942 [details]
Patch
Comment 2 Steve Falkenburg 2011-05-26 01:57:40 PDT
All of these directories are empty, which is intentional.
Their presence is required to indicate that the WebKit2WebProcess has localizations available for these languages.
Comment 3 Steve Falkenburg 2011-05-26 01:58:19 PDT
Here's the svn st:

$ svn st
M       ChangeLog
A       win/WebKit2WebProcess.resources/ja.lproj
A       win/WebKit2WebProcess.resources/zh_TW.lproj
A       win/WebKit2WebProcess.resources/fi.lproj
A       win/WebKit2WebProcess.resources/nb.lproj
A       win/WebKit2WebProcess.resources/zh_CN.lproj
A       win/WebKit2WebProcess.resources/es.lproj
A       win/WebKit2WebProcess.resources/fr.lproj
A       win/WebKit2WebProcess.resources/ko.lproj
A       win/WebKit2WebProcess.resources/nl.lproj
A       win/WebKit2WebProcess.resources/pl.lproj
A       win/WebKit2WebProcess.resources/it.lproj
A       win/WebKit2WebProcess.resources/pt.lproj
A       win/WebKit2WebProcess.resources/da.lproj
A       win/WebKit2WebProcess.resources/ru.lproj
A       win/WebKit2WebProcess.resources/pt_PT.lproj
A       win/WebKit2WebProcess.resources/de.lproj
A       win/WebKit2WebProcess.resources/sv.lproj
A       win/WebKit2WebProcess.resources/English.lproj
Comment 4 Steve Falkenburg 2011-05-26 02:16:40 PDT
Created attachment 94947 [details]
Patch
Comment 5 Adam Roben (:aroben) 2011-05-26 04:39:15 PDT
Comment on attachment 94947 [details]
Patch

Do we know why this isn't needed on Mac?
Comment 6 Steve Falkenburg 2011-05-26 09:35:38 PDT
Committed r87394: <http://trac.webkit.org/changeset/87394>
Comment 7 Steve Falkenburg 2011-05-26 10:01:50 PDT
Created attachment 94994 [details]
Patch
Comment 8 Adam Roben (:aroben) 2011-05-26 10:03:29 PDT
Comment on attachment 94994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94994&action=review

> Source/WebKit2/win/WebKit2WebProcess.resources/Info.plist:20
>  	<string>WebKit2WebProcess</string>
>  	<key>CFBundlePackageType</key>
>  	<string>APPL</string>
> +  <key>CFBundleAllowMixedLocalizations</key>
> +  <string>YES</string>

Differing indentation here.
Comment 9 Steve Falkenburg 2011-05-26 10:05:25 PDT
Committed r87397: <http://trac.webkit.org/changeset/87397>