Bug 61493 - Switch positionOverflowControls to IntPoint
Summary: Switch positionOverflowControls to IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2011-05-25 18:08 PDT by Levi Weintraub
Modified: 2011-05-26 15:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.42 KB, patch)
2011-05-25 20:03 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2011-05-26 13:49 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-05-25 18:08:07 PDT
More tx/ty removal.
Comment 1 Levi Weintraub 2011-05-25 20:03:58 PDT
Created attachment 94908 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-26 06:28:35 PDT
Comment on attachment 94908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94908&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2030
> +    IntRect absBounds(borderBox.x() + offsetFromLayer.x(), borderBox.y() + offsetFromLayer.y(), borderBox.width(), borderBox.height());

And here... :)  Definitely a size.   (I've yet to see the true appeal of the size vs. point dichotomy.  Mostly it's just a pain to work with.)

> Source/WebCore/rendering/RenderLayer.cpp:2046
> +            layer->setPosition(IntPoint(m_hBar->frameRect().x() - offsetFromLayer.y(), m_hBar->frameRect().y() - offsetFromLayer.y()));

Seems this wants to be a size, cause then you would just do point math there.

> Source/WebCore/rendering/RenderLayer.cpp:2053
> +            layer->setPosition(IntPoint(m_vBar->frameRect().x() - offsetFromLayer.x(), m_vBar->frameRect().y() - offsetFromLayer.y()));

And here.
Comment 3 Levi Weintraub 2011-05-26 13:49:52 PDT
Created attachment 95031 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-05-26 14:54:48 PDT
Comment on attachment 95031 [details]
Patch

LGTM.
Comment 5 Levi Weintraub 2011-05-26 15:06:58 PDT
Comment on attachment 95031 [details]
Patch

Clearing flags on attachment: 95031

Committed r87437: <http://trac.webkit.org/changeset/87437>
Comment 6 Levi Weintraub 2011-05-26 15:07:03 PDT
All reviewed patches have been landed.  Closing bug.