RESOLVED FIXED 61493
Switch positionOverflowControls to IntPoint 
https://bugs.webkit.org/show_bug.cgi?id=61493
Summary Switch positionOverflowControls to IntPoint
Levi Weintraub
Reported 2011-05-25 18:08:07 PDT
More tx/ty removal.
Attachments
Patch (4.42 KB, patch)
2011-05-25 20:03 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (4.25 KB, patch)
2011-05-26 13:49 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-25 20:03:58 PDT
Created attachment 94908 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-26 06:28:35 PDT
Comment on attachment 94908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94908&action=review > Source/WebCore/rendering/RenderLayer.cpp:2030 > + IntRect absBounds(borderBox.x() + offsetFromLayer.x(), borderBox.y() + offsetFromLayer.y(), borderBox.width(), borderBox.height()); And here... :) Definitely a size. (I've yet to see the true appeal of the size vs. point dichotomy. Mostly it's just a pain to work with.) > Source/WebCore/rendering/RenderLayer.cpp:2046 > + layer->setPosition(IntPoint(m_hBar->frameRect().x() - offsetFromLayer.y(), m_hBar->frameRect().y() - offsetFromLayer.y())); Seems this wants to be a size, cause then you would just do point math there. > Source/WebCore/rendering/RenderLayer.cpp:2053 > + layer->setPosition(IntPoint(m_vBar->frameRect().x() - offsetFromLayer.x(), m_vBar->frameRect().y() - offsetFromLayer.y())); And here.
Levi Weintraub
Comment 3 2011-05-26 13:49:52 PDT
Created attachment 95031 [details] Patch
Eric Seidel (no email)
Comment 4 2011-05-26 14:54:48 PDT
Comment on attachment 95031 [details] Patch LGTM.
Levi Weintraub
Comment 5 2011-05-26 15:06:58 PDT
Comment on attachment 95031 [details] Patch Clearing flags on attachment: 95031 Committed r87437: <http://trac.webkit.org/changeset/87437>
Levi Weintraub
Comment 6 2011-05-26 15:07:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.