Bug 61479 – MemoryPressureHandler class should not be in WebCore/platform

• Status: ASSIGNED
• Component: WebCore Misc.

[Michael Saboff]

A comment came in after https://bugs.webkit.org/show_bug.cgi?id=61222 was landed that the new class, WebCore::MemoryPressureHandler, should not be in WebCore/platform.  The key point from the comment is "... files in platform/ should not be including or using classes outside of platform (and not in WTF or JSC) such as MemoryCache or PageCache.  We consider this to be a layering violation in WebCore."

It has been suggested that this class be moved to WebCore/page.

[Mustafizur Rahaman (rahaman)]

Created attachment 100453 [details]
Proposed Patch

Moved the MemoryPressureHandler* source/header files from WebCore/platform to WebCore/page

[Michael Saboff]

I think you also need to change Source/WebCore/WebCore.xcodeproj/project.pbxproj to support the move on Mac.  Besides that, the change looks good.

[Sam Weinig]

Comment on attachment 100453 [details]
Proposed Patch

As Michael said, this will break the mac as is.

[Mustafizur Rahaman (rahaman)]

Created attachment 100771 [details]
Patch to incorporate Michael & Sam's review comment

Modified the xcodeproj file & now it is building fine in Mac.

[Sam Weinig]

Can you upload another one that merges cleanly with the bots so that we can see it if it really builds on the mac.

[Mustafizur Rahaman (rahaman)]

Created attachment 100936 [details]
Patch re-created on latest code base

There was problem applying the previous patch. So, recreated the patch on the latest code base.

[Sam Weinig]

Comment on attachment 100936 [details]
Patch re-created on latest code base

This will break the Lion build. You need to migrate MemoryPressureHandlerMac.mm as well.

[Yongjun Zhang]

Created attachment 123020 [details]
Move MemoryPressureHandler class from WebCore/platform to WebCore/page.

[Gustavo Noronha (kov)]

Comment on attachment 123020 [details]
Move MemoryPressureHandler class from WebCore/platform to WebCore/page.

Attachment 123020 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11282454

[Yongjun Zhang]

Created attachment 123065 [details]
fix gtk build break.

[Yongjun Zhang]

Created attachment 123141 [details]
Fix win build break.

[Eric Seidel (no email)]

Comment on attachment 123141 [details]
Fix win build break.

Seems reasonable.

[WebKit Review Bot]

Comment on attachment 123141 [details]
Fix win build break.

Rejecting attachment 123141 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
.mm
patching file Source/WebCore/platform/MemoryPressureHandler.cpp
rm 'Source/WebCore/platform/MemoryPressureHandler.cpp'
patching file Source/WebCore/platform/MemoryPressureHandler.h
rm 'Source/WebCore/platform/MemoryPressureHandler.h'
patching file Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
rm 'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm'

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1

Full output: http://queues.webkit.org/results/11365779