Bug 61478 - Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
Summary: Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-25 15:47 PDT by Michael Saboff
Modified: 2011-05-25 16:05 PDT (History)
0 users

See Also:


Attachments
Patch with requested style changes. (4.67 KB, patch)
2011-05-25 15:48 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-05-25 15:47:21 PDT
There were some comments made to https://bugs.webkit.org/show_bug.cgi?id=61222 that didn't make it into the landed patch.  This includes using /2 instead of >>1, adding a blank line after class include,making method names start with lower case and adding clarifying comments.

-    
-    void pruneDeadResources(); // Flush decoded and encoded data from resources not referenced by Web pages.
-    void pruneLiveResources(); // Flush decoded data from resources still referenced by Web pages.
 
+    // pruneDead*() - Flush decoded and encoded data from resources not referenced by Web pages.
+    // pruneLive*() - Flush decoded data from resources still referenced by Web pages.
+    void pruneDeadResources(); // Automatically decide how much to prune.
+    void pruneLiveResources();
+    void PruneDeadResourcesToPercentage(float prunePercentage);
+    void PruneLiveResourcesToPercentage(float prunePercentage);

Functions should not start with capital letters. 

Added: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (0 => 87228)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	                        (rev 0)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2011-05-24 23:43:15 UTC (rev 87228)
...
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import "MemoryPressureHandler.h"
+#import <WebCore/GCController.h>
+#import <WebCore/MemoryCache.h>
+#import <WebCore/PageCache.h>
+#import <wtf/FastMalloc.h>

There should be a newline after MemoryPressureHandler.h, and this should not be using <WebCore/*> style includes for files in WebCore.
Comment 1 Michael Saboff 2011-05-25 15:48:32 PDT
Created attachment 94874 [details]
Patch with requested style changes.
Comment 2 Michael Saboff 2011-05-25 16:05:46 PDT
Committed r87330: <http://trac.webkit.org/changeset/87330>